tracker issue : CF-3807350

select a category, or use search below
(searches all categories and all time range)
Title:

Inconsistent naming standard between DecodeForHTML and DecodeFromURL

| View in Tracker

Status/Resolution/Reason: Closed/Withdrawn/AsDesigned

Reporter/Name(from Bugbase): George Alsobrooks / George Alsobrooks (GEORGE ALSOBROOKS)

Created: 08/18/2014

Components: Security

Versions: 10.0

Failure Type: Cosmetic Issue

Found In Build/Fixed In Build: Final /

Priority/Frequency: Normal / All users will encounter

Locale/System: English / Win 2008 Server R2 64 bit

Vote Count: 0

Function name DecodeForHTML should be renamed to DecodeFromHTML.  ColdFusion 10 added several commands to EncodeForXXXXX.  These are all named consistently and start with ‘EncodeFor’.  There are currently only two Decode commands and they are named inconsistently.    One starts with ‘DecodeFor’ and the other starts with ‘DecodeFrom’.

I recommend renaming DecodeForHTML since it is not actually decoding the string FOR html.  Instead it is taking an HTML string and decoding to ‘normal’ text.  However, either one could be used as the standard.

<https://wikidocs.adobe.com/wiki/display/coldfusionen/DecodeForHTML>
<https://wikidocs.adobe.com/wiki/display/coldfusionen/DecodeFromURL>


This is only a standardization issue, but if not corrected early will only continue as other Decoders are added to the language.

----------------------------- Additional Watson Details -----------------------------

Watson Bug ID:	3807350

External Customer Info:
External Company:  
External Customer Name: ImpDust
External Customer Email:  
External Test Config: N/A

Attachments:

Comments:

The method name is exactly same as ESAPI. Closing it.
Comment by Rupesh K.
11341 | November 12, 2014 10:50:58 PM GMT
Thanks for looking into it. I can understand why you'd want to stick with the name in the underlying ESAPI even if it is inconsistent.
Comment by External U.
11342 | November 13, 2014 05:47:05 AM GMT