Title:
inconsistent_use_of underscores_in cfschedule's result_fields_and attribute_values
| View in TrackerStatus/Resolution/Reason: Closed/Fixed/
Reporter/Name(from Bugbase): Aaron Neff / Aaron Neff (Aaron Neff)
Created: 05/18/2012
Components: Scheduler
Versions: 10.0
Failure Type:
Found In Build/Fixed In Build: Final / 283018,285188
Priority/Frequency: Minor / Some users will encounter
Locale/System: English / Win All
Vote Count: 1
First_Issue:
-----------
<cfschedule inconsistently uses underscores for new attribute values. Example:
Look at this line of code: <cfschedule onmisfire="fire_now" onexception="invokehandler"
See? Both values are 2-words and both were added in CF10, but only one of them uses an underscore.
Thus, "fire_now" should be "firenow".
-----------
Second_Issue:
-----------
<cfschedule inconsistently uses underscores for result field names. Repro:
a) Run this: <cfschedule action="list" result="q" /><cfdump var="#q#" />
b) See these fields: CHAINED_TASK, LAST_FIRE, PROXY_PORT, PROXY_SERVER, REMAINING_COUNT, RESOLVE_URL, RETRY_COUNT
c) Also see these fields: CRONTIME, ENDDATE, ENDTIME, EVENTHANDLER, STARTDATE, STARTTIME
So now developers have to remember which ones use underscores and which ones don't. That causes confusion and should be cleaned up in the next release. For consistency w/ the rest of the language (i.e. cfquery's result struct, cfhttp's result struct, etc) the underscores in cfschedule's result struct should be removed.
It was stated that underscores make the terms more readable. Well..
What about cfchedule's actions: action="pauseall", action="resumeall", onexception="invokehandler", and onmisfire="invokehandler?
Should those be: cron_time, end_date, end_time, event_handler, start_date, start_time, pause_all, resume_all, invoke_handler?
What about cfhttp’s result variables: charset, errordetail, filecontent, mimetype, responseheader, statuscode?
Should those be: char_set, error_detail, file_content, mime_type, response_header, status_code?
What about getTimeZoneInfo()’s result variables: utcTotalOffset, utcHourOffset, utcMinuteOffset, isDSTOn?
Should those be: utc_total_offset, utc_hour_offset, utc_minute_offset, is_dst_on?
What about cfdirectory’s datelastmodified result value? Should that be date_last_modified?
What about getFileInfo()’s result variables: lastmodified, canread, canwrite, ishidden?
Should those be: last_modified, can_read, can_write, is_hidden?
What about cfquery’s result variables: recordcount, sqlparameters, columnlist, executiontime, generatedkey?
Should those be: record_count, sql_parameters, column_list, execution_time, generated_key?
(The above tags/functions are just some of the examples. I understand CGI variables use underscores, and that cfqueryparam’s cfsqltype attribute takes values having underscores, and that the old db-specific cfquery result variables for the ID of the inserted row used underscores, but MOST of the examples in CF do not use underscores to join words)
----------------------------- Additional Watson Details -----------------------------
Watson Bug ID: 3194042
Keywords:
FixTested
External Customer Info:
External Company:
External Customer Name: itisdesign
External Customer Email:
Attachments:
Comments: