tracker issue : CF-4202903

Issue: FindAll must simply be the "find all" variant

Notes (for language consistency/predictability):
1) ArrayFindAll() must simply be the "find all" variant of ArrayFind()
2) ArrayFindAllNoCase() must simply be the "find all" variant of ArrayFindNoCase()

Thus, if:
- ArrayFind() searches a haystack for the 1st matching needle
and
- ArrayFindNoCase() *only* string-searches a haystack for the 1st matching case-insensitive string

Then:
- ArrayFindAll() must search a haystack for all matching needles
and
- ArrayFindAllNoCase() must *only* string-search a haystack for all matching case-insensitive strings

Important: The word "All" doesn't mean it searches for more -types-. It means that it searches for more _positions_.

Repro:
{code:java}
<cfscript>
  haystack = [{foo="Bar"},function(){return true}]
  
  arrayFind(haystack, {foo="Bar"})//no error
  arrayFind(haystack, function(){return true})//no error
  arrayFindNoCase(haystack, {foo="Bar"})//exception
  arrayFindNoCase(haystack, function(){return true})//exception
  
  arrayFindAll(haystack, {foo="Bar"})//no error
  arrayFindAll(haystack, function(){return true})//no error
  arrayFindAllNoCase(haystack, {foo="Bar"})//no error
  arrayFindAllNoCase(haystack, function(){return true})//no error
</cfscript>
{code}


Actual Result: arrayFindAll() is simply the "find all" variant of arrayFind() (good), but arrayFindAllNoCase() is not simply the "find all" variant of arrayFindNoCase().

Expected Result: "FindAll" is simply the "find all" variant.

See? arrayFind() only does a string-search. But, arrayFindAllNoCase() searches for _more types_ (i.e. it doesn't *only* do a string search, and therefore is _not_ the "find all" variant of arrayFindNoCase()).

Thus, in the above repro, either A) arrayFindNoCase() must not throw an exception or B) arrayFindAllNoCase() must throw an exception.

Attachments:

Comments: