Title:
CFFTP close action results in org.apache.commons.net.ftp.FTPConnectionClosedException
| View in TrackerStatus/Resolution/Reason: Closed/Withdrawn/NotABug
Reporter/Name(from Bugbase): A. B. / ()
Created: 07/01/2019
Components: Net Protocols, FTP
Versions: 2018
Failure Type:
Found In Build/Fixed In Build: 2018.0.03.314033 /
Priority/Frequency: Normal /
Locale/System: / Win 2016
Vote Count: 0
Problem Description:
A CFM page runs the following FTP tags once a day, using the same connection, named "cbFtpConnection":
<cfftp action="open">, <cfftp action="listdir"> and <cfftp action="getfile">
These all work as expected. After all the processing is finished, we end with
<cfftp action="close" connection="cbFtpConnection">
The close action usually works as expected. However, of recent, it results in the exception org.apache.commons.net.ftp.FTPConnectionClosedException.
Steps to Reproduce:
The following code runs once daily as a scheduled task (private and sensitive information deleted):
<cfif IsDefined("url.requestTimeOut")>
<cfset rqto = url.requestTimeOut />
<cfelse>
<cfset rqto = 7200 />
</cfif>
<cfsetting requesttimeout="#rqto#" showdebugoutput="false">
<cfquery name="qCheckRunningQueue" datasource="#application.settings.DSN#">
SELECT JOB_NAME
, JOB_START_DATE
FROM PROCESSES.RUNNING_JOBS
WHERE JOB_NAME = <cfqueryparam cfsqltype="CF_SQL_VARCHAR" value="CheckSentCBOrders" />
AND DATEADD(SECOND, TIME_OUT, JOB_START_DATE) > GETDATE()
</cfquery>
<cfif qCheckRunningQueue.recordCount neq 0>
<cfmail from="#application.INSTANCE_NAME#@stdmtr.nl" to="dkklp@uitg-dev.nl,error@stdmtr.nl" subject="Failed to start: #qCheckRunningQueue.job_name[1]#" type="html">
De job #qCheckRunningQueue.job_name[1]# is al eerder gestart op #qCheckRunningQueue.job_start_date[1]#.
</cfmail>
<cfthrow message = "Failed to start: #qCheckRunningQueue.job_name[1]#" />
<cfelse>
<cfquery name="qInsertJobIntoRunningQueue" datasource="#application.settings.DSN#">
INSERT INTO PROCESSES.RUNNING_JOBS
( JOB_NAME
, TIME_OUT
)
VALUES (
<cfqueryparam cfsqltype="CF_SQL_VARCHAR" value="CheckSentCBOrders" />
, <cfqueryparam cfsqltype="CF_SQL_INTEGER" value="#rqto#" />
)
</cfquery>
<cfset cbFtpConnection = "" />
<cfftp action="open" retrycount="2" stoponerror="true" server="ftp1.boekhuis.nl" username="*********" password="*********" connection="cbFtpConnection" />
<cfftp action="listdir" directory="/out" name="ftpContent" connection="cbFtpConnection" passive="true" />
<cfif ftpContent.recordCount neq 0>
<!---Sort results on date --->
<cfquery name="ftpContentSorted" dbtype="query">
SELECT *
FROM ftpContent
ORDER BY LastModified
</cfquery>
<cfloop query="ftpContentSorted">
<cfif Find(".uit", ftpContentSorted.name[ftpContentSorted.currentRow])>
<cfftp action="getfile" localfile="#GetTempDirectory()#/#ftpContentSorted.name[ftpContentSorted.currentRow]#" remotefile="/out/#ftpContentSorted.name[ftpContentSorted.currentRow]#" connection="cbFtpConnection" transfermode="ascii" passive="true" failIfExists="false" />
<cffile action="read" file="#GetTempDirectory()#/#ftpContentSorted.name[ftpContentSorted.currentRow]#" variable="localFile" >
<cfset application.objectStoreWrapper.uploadToFileStorage(targetFileLocation="files/dev/CB_UIT/",
targetFilename=ftpContentSorted.name[ftpContentSorted.currentRow],
sourceFilename=ftpContentSorted.name[ftpContentSorted.currentRow]) />
<cfset fileRows = ListToArray(localFile,"#chr(13)##chr(10)#") />
<cfset recordFound = false />
<cfset isNewOrder = false />
<cfset errorFound = false />
<cfset errorMessage = "" />
<cfset orderId = "" />
<cfset sentDate = DateFormat(Now(), "YYYY-MM-DD") />
<cfset fileRows_length = ArrayLen(fileRows) />
<cfloop from="1" to="#fileRows_length#" index="i">
<cfif Find("##00010", fileRows[i]) neq 0>
<cfset sentDatePos = Find("##0004", fileRows[i]) />
<cfset nextPos = Find("##", fileRows[i], sentDatePos+5)-(sentDatePos+5) />
<cfset sentDate = Mid(fileRows[i], sentDatePos+5, nextPos) />
<cfset sentDate = Left(sentDate, 4) & "-" & Mid(sentDate, 5, 2) & "-" & Right(sentDate, 2) />
<cfelseif Find("##00014", fileRows[i]) neq 0>
<cfset recordFound = true />
<cfset orderReferencePos = Find("##0403", fileRows[i]) />
<cfset nextPos = Find("##", fileRows[i], orderReferencePos+5)-(orderReferencePos+5) />
<cfset orderId = Mid(fileRows[i], orderReferencePos+5, nextPos) />
<cfif Left(orderId, 1) eq "6" and Len(orderId) eq 8 and IsNumeric(orderId)>
<cfset isNewOrder = true />
Order: <cfoutput>#orderId#</cfoutput><br/>
<cfset eanPos = Find("##0200", fileRows[i]) />
<cfset nextPos = Find("##", fileRows[i], eanPos+5)-(eanPos+5) />
<cfset ean = Mid(fileRows[i], eanPos+5, nextPos) />
- EAN: <cfoutput>#ean#</cfoutput><br/>
<cfset amountPos = Find("##0430", fileRows[i]) />
<cfset nextPos = Find("##", fileRows[i], amountPos+5)-(amountPos+5) />
<cfif nextPos eq -(amountPos+5)>
<cfset nextPos = Len(fileRows[i]) - (amountPos+5) - 1 />
</cfif>
<cfset amount = Trim(Mid(fileRows[i], amountPos+5, nextPos)) />
- Aantal geleverd: <cfoutput>#amount#</cfoutput><br/>
<cfset tntPos = Find("##0462", fileRows[i]) />
<cfif tntPos neq 0>
<cfset nextPos = Find("##", fileRows[i], tntPos+5)-(tntPos+5) />
<cfif nextPos eq -(tntPos+5)>
<cfset nextPos = Len(fileRows[i]) - (tntPos+5) - 1 />
</cfif>
<cfset tnt = Trim(Mid(fileRows[i], tntPos+5, nextPos)) />
<cfelse>
<cfset tnt = "" />
</cfif>
- Track & trace code: <cfoutput>#tnt#</cfoutput><br/>
<cfsavecontent variable="xmlFilter">
<cfoutput>
<filters>
<filter FilterId="orderId">
<field FieldId="ProfitOrderNummer" OperatorType="1">#orderId#</field>
<field FieldId="ean" OperatorType="1">#ean#</field>
</filter>
</filters>
</cfoutput>
</cfsavecontent>
<cfset findOrderResult = application.profitService.GetConnector("devVerkooporderregels", xmlFilter) />
<cfif StructKeyExists(findOrderResult.Envelope.Body.GetDataResponse.GetDataResult.AfasGetConnector, "devVerkooporderregels")>
<cfsavecontent variable="xmlData">
<cfoutput>
<FbSales xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<Element>
<!--- private xml content --->
</Element>
</FbSales>
</cfoutput>
</cfsavecontent>
<cfset updateResult = application.profitService.updateConnector("FbSales", xmlData) />
Profit orderline modified!<br/>
<cfsavecontent variable="xmlData">
<cfoutput>
<FbDeliveryNote xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<Element>
<!--- private xml content --->
</Element>
</FbDeliveryNote>
</cfoutput>
</cfsavecontent>
<cfset result = application.profitService.updateConnector("FbDeliveryNote", xmlData) />
Profit delivery added!<br/>
<cfelse>
Profit order NOT found!!!<br/>
</cfif>
<br/>
<cfelse>
Oude order of directe order via CB Online: <cfoutput>#orderId#</cfoutput><br/>
GEEN ACTIE!<br/>
</cfif>
</cfif>
</cfloop>
</cfif>
<br/>
</cfloop>
</cfif>
<!--- the line \scheduled\finance\CheckSentCBOrders.cfm:213 in the stacktrace-->
<cfftp action="close" connection="cbFtpConnection" />
Actual Result: The code is a CFM that runs once daily as a scheduled task. It does what we expect it to do, with one exception: the last line (FTP close) throws an FTPConnectionClosedException on some days. See attached stacktrace.
Expected Result:
No FTPConnectionClosedException exception, especially as that is what the tag <cfftp action="close"> is supposed to do.
Any Workarounds:
None knownAttachments:
Comments: